Looks great!

Please add doxygen comments about CFGInitializer and CFGAutomaticObjDtor 
respectively.  We should get in the habit of documenting such core classes in 
the static analyzer.

We also should probably add a FileCheck-based test to test/Analysis that tests 
CFG printing (particularly these new pieces), since it has broken in the past.  
Now that we're adding new CFGElements, now seems like a good time to start 
testing this.

On Sep 20, 2010, at 4:42 PM, Marcin Świderski wrote:

> This patch:
> - defines interfaces for CFGInitializer and CFGAutomaticObjDtor,
> - adds support for above classes to print_elem function (renamed print_stmt)
> 
> I've extended StmtPrinterHelper to print locations of VarDecls for 
> destructors.
> 
> Please aprove for commit,
> 
> Marcin
> <cfg-print-elem.patch>


_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to