Added comments. I thought about tests myself but don't really know how should we go about them? I mean that for now destructors will probably be off by default. How to print CFG using the driver? How to set up testing the output?
W dniu 21 września 2010 03:24 użytkownik Ted Kremenek <[email protected]>napisał: > Looks great! > > Please add doxygen comments about CFGInitializer and CFGAutomaticObjDtor > respectively. We should get in the habit of documenting such core classes > in the static analyzer. > > We also should probably add a FileCheck-based test to test/Analysis that > tests CFG printing (particularly these new pieces), since it has broken in > the past. Now that we're adding new CFGElements, now seems like a good time > to start testing this. > > On Sep 20, 2010, at 4:42 PM, Marcin Świderski wrote: > > > This patch: > > - defines interfaces for CFGInitializer and CFGAutomaticObjDtor, > > - adds support for above classes to print_elem function (renamed > print_stmt) > > > > I've extended StmtPrinterHelper to print locations of VarDecls for > destructors. > > > > Please aprove for commit, > > > > Marcin > > <cfg-print-elem.patch> > >
cfg-print-elem.patch
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
