Applied at r121873, thanks for reviewing!

-Argiris

On Dec 14, 2010, at 11:55 PM, Chris Lattner wrote:

> Looks great to me!
> 
> -Chris
> 
> On Dec 10, 2010, at 1:25 PM, Argyrios Kyrtzidis wrote:
> 
>> *bump*
>> 
>> updated for trunk patch attached.
>> <diag-pragma.diff>
>> On Dec 1, 2010, at 3:27 PM, Argyrios Kyrtzidis wrote:
>> 
>>> The attached patch fixes diagnostic pragmas to keep track of the diagnostic 
>>> state changes.
>>> 
>>> This is an improved version of the earlier patch, where the main change is 
>>> that macros that require 'unused' warnings
>>> are tracked by the Preprocessor by storing their source locations. The 
>>> benefit of this is that when we are
>>> deserializing from PCH, we don't need to deserialize identifier & macros 
>>> just so that we can report that they are unused,
>>> we just warn using the SourceLocations of the set (that will be filled by 
>>> the ASTReader, though ASTReader/ASTWriter changes will come in later).
>>> 
>>> Please review.
>>> 
>>> -Argiris
>>> <diag-pragma.diff>_______________________________________________
>>> cfe-commits mailing list
>>> [email protected]
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>> 
>> _______________________________________________
>> cfe-commits mailing list
>> [email protected]
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 
> 
> _______________________________________________
> cfe-commits mailing list
> [email protected]
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits


_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to