Sorry, forgot to attach the patch. Cheers, Caitlin
On Thu, Jun 30, 2011 at 2:26 PM, Caitlin Sadowski <[email protected]> wrote: > And here is a third patch that replaces instances of: > > "Attr.isInvalid() == false" with "!Attr.isInvalid()" > > Cheers, > > Caitlin > > On Thu, Jun 30, 2011 at 12:13 PM, Caitlin Sadowski <[email protected]> > wrote: >> Here is an updated version of the second patch, incorporating feedback >> from code review. >> >> Cheers, >> >> Caitlin >> >> On Wed, Jun 29, 2011 at 10:36 AM, Caitlin Sadowski <[email protected]> >> wrote: >>> Actually, I meant to send out this version of the second patch >>> (identical except that there is unsigned int instead of int in the >>> helper function). >>> >>> Cheers, >>> >>> Caitlin >>> >>> On Tue, Jun 28, 2011 at 3:23 PM, Caitlin Sadowski <[email protected]> >>> wrote: >>>> Here is a second refactoring patch, building on the 1 character patch >>>> sent out previously, which refactors SemaDeclAttr to use a helper >>>> method when checking if the number of args matches, if the expected >>>> number is the same as the check. >>>> >>>> Also, feel free to give code review comments: >>>> >>>> http://codereview.appspot.com/4635075 >>>> >>>> Cheers, >>>> >>>> Caitlin >>>> >>>> On Mon, Jun 27, 2011 at 6:44 PM, Caitlin Sadowski <[email protected]> >>>> wrote: >>>>> This bugfix corrects a suspected mismatch between the number of >>>>> arguments expected and the number listed in the error message if less >>>>> arguments are presented in HandleReqdWorkGroupSize. >>>>> >>>>> Cheers, >>>>> >>>>> Caitlin >>>>> >>>> >>> >> >
From f56b4252210eb0306210430dfa65ac9b08461b2f Mon Sep 17 00:00:00 2001 From: Caitlin Sadowski <[email protected]> Date: Thu, 30 Jun 2011 14:12:25 -0700 Subject: [PATCH] Refactoring SemaDeclAttr to remove occurances of Attr.isInvalid() == false --- lib/Sema/SemaDeclAttr.cpp | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/Sema/SemaDeclAttr.cpp b/lib/Sema/SemaDeclAttr.cpp index 1d6f66e..5e66e17 100644 --- a/lib/Sema/SemaDeclAttr.cpp +++ b/lib/Sema/SemaDeclAttr.cpp @@ -812,7 +812,7 @@ static void HandleMayAliasAttr(Decl *d, const AttributeList &Attr, Sema &S) { } static void HandleNoCommonAttr(Decl *d, const AttributeList &Attr, Sema &S) { - assert(Attr.isInvalid() == false); + assert(!Attr.isInvalid()); if (isa<VarDecl>(d)) d->addAttr(::new (S.Context) NoCommonAttr(Attr.getLoc(), S.Context)); else @@ -821,7 +821,7 @@ static void HandleNoCommonAttr(Decl *d, const AttributeList &Attr, Sema &S) { } static void HandleCommonAttr(Decl *d, const AttributeList &Attr, Sema &S) { - assert(Attr.isInvalid() == false); + assert(!Attr.isInvalid()); if (isa<VarDecl>(d)) d->addAttr(::new (S.Context) CommonAttr(Attr.getLoc(), S.Context)); else @@ -2482,7 +2482,7 @@ static void HandleCallConvAttr(Decl *d, const AttributeList &attr, Sema &S) { } static void HandleOpenCLKernelAttr(Decl *d, const AttributeList &Attr, Sema &S){ - assert(Attr.isInvalid() == false); + assert(!Attr.isInvalid()); d->addAttr(::new (S.Context) OpenCLKernelAttr(Attr.getLoc(), S.Context)); } -- 1.7.3.1
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
