It also looks like perhaps this patch was never applied... Cheers,
Caitlin On Thu, Jun 30, 2011 at 2:27 PM, Caitlin Sadowski <[email protected]> wrote: > Sorry, forgot to attach the patch. > > Cheers, > Caitlin > > On Thu, Jun 30, 2011 at 2:26 PM, Caitlin Sadowski <[email protected]> wrote: >> And here is a third patch that replaces instances of: >> >> "Attr.isInvalid() == false" with "!Attr.isInvalid()" >> >> Cheers, >> >> Caitlin >> >> On Thu, Jun 30, 2011 at 12:13 PM, Caitlin Sadowski <[email protected]> >> wrote: >>> Here is an updated version of the second patch, incorporating feedback >>> from code review. >>> >>> Cheers, >>> >>> Caitlin >>> >>> On Wed, Jun 29, 2011 at 10:36 AM, Caitlin Sadowski <[email protected]> >>> wrote: >>>> Actually, I meant to send out this version of the second patch >>>> (identical except that there is unsigned int instead of int in the >>>> helper function). >>>> >>>> Cheers, >>>> >>>> Caitlin >>>> >>>> On Tue, Jun 28, 2011 at 3:23 PM, Caitlin Sadowski <[email protected]> >>>> wrote: >>>>> Here is a second refactoring patch, building on the 1 character patch >>>>> sent out previously, which refactors SemaDeclAttr to use a helper >>>>> method when checking if the number of args matches, if the expected >>>>> number is the same as the check. >>>>> >>>>> Also, feel free to give code review comments: >>>>> >>>>> http://codereview.appspot.com/4635075 >>>>> >>>>> Cheers, >>>>> >>>>> Caitlin >>>>> >>>>> On Mon, Jun 27, 2011 at 6:44 PM, Caitlin Sadowski <[email protected]> >>>>> wrote: >>>>>> This bugfix corrects a suspected mismatch between the number of >>>>>> arguments expected and the number listed in the error message if less >>>>>> arguments are presented in HandleReqdWorkGroupSize. >>>>>> >>>>>> Cheers, >>>>>> >>>>>> Caitlin >>>>>> >>>>> >>>> >>> >> > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
