FYI, comments on the codereview page. =] Thanks! On Fri, Jul 15, 2011 at 5:06 PM, Kaelyn Uhrain <[email protected]> wrote:
> This patch improves how typo correction deals with overloaded functions, > e.g. Sema::CorrectTypo now returns a set of Decls in the TypoCorrection if > the lookup of a correction has a result kind of > LookupResult::FoundOverloaded, and Sema::DiagnoseEmptyLookup has been > modified to try to choose the best Decl from the set. With these changes, > TypoCorrection is one step closer to never returning a non-keyword > correction with a NULL Decl. I also ran memcheck using > test/FixIt/typo-crash.cpp as a quick sanity check that I didn't accidentally > introduce any memory leaks with the changes to the TypoCorrection class > (though I think dynamically allocating the UnresolvedSet may be a bit of > overkill and generally unnecessary--thoughts?). > > The changes can also be reviewed at: http://codereview.appspot.com/4747047 > > Cheers, > Kaelyn > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
