On Mon, Aug 1, 2011 at 4:25 PM, Kaelyn Uhrain <[email protected]> wrote:

> The use of a special non-NULL value for the CorrectionDecl* was needed when
> the TypoCorrection stored just one NamedDecl pointer to avoid an extra
> internal boolean flag and a bunch of handling for it, but is unneeded now
> that TypoCorrection stores a list of NamedDecl pointers (can now do empty
> list vs NULL first element). I've attached the updated patch for real this
> time--sorry for accidentally sending my previous email with a missing
> attachment.


This looks pretty good to me. Can you comment (maybe around isKeyword,
and/or any other relevant function) that we represent a keyword result with
a null pointer in the decls vector?

Thanks!
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to