On Sat, Oct 15, 2011 at 12:02:13AM -0400, Rafael Espíndola wrote: > > The savectx "builtin" creates warning regressions for NetBSD and > > supposedly the other BSDs. I can't find any source for savectx and > > qsetjmp with google -- at least savectx was originally questioned when > > it was added in LLVM. Does anywhere know a system where they do exist? > > Otherwise I would advocate to just remove them from the list. > > The waring is because is because the declarations are not matching. It > looks like you found a system with savectx :-), what is the signature? > Can you update Builtins.def?
void savectx(struct pcb *); Does that sound like anything with a relation to setjmp? Even if it returns twice, it can and should be marked as such. I still don't believe it belongs on any magic builtin list. > If you are sure that savectx doesn't return twice, please check with > the gcc folks too. They have the equivalent code since 1992 at least: > > http://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=66d433c7be147672fb1da1afd42a311d79cb0531 I don't believe in cargo cult programming, so this doesn't exactly sound like a good reason for keeping it. > What does savectx do on your system? It's an internal function, used to synchronise some data structure before creating a new thread, exposed to userland for various (slightly broken...) reasons. Joerg _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
