Thanks, r143972.

On Mon, Nov 7, 2011 at 10:14, David Blaikie <[email protected]> wrote:
>> Appease -Wnon-virtual-dtor
>
>> +    virtual ~PseudoOpBuilder() {}
>> +
>
> It looks like the right thing to do is to make the dtor protected and
> non-virtual (this should still silence the warning), as no users
> actually try to destroy these objects polymorphically. (
> http://www.gotw.ca/publications/mill18.htm )
>
> - David
>

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to