On Mon, Nov 7, 2011 at 10:14 AM, David Blaikie <[email protected]> wrote:
> > Appease -Wnon-virtual-dtor
>
> > + virtual ~PseudoOpBuilder() {}
> > +
>
> It looks like the right thing to do is to make the dtor protected and
> non-virtual (this should still silence the warning), as no users
> actually try to destroy these objects polymorphically. (
> http://www.gotw.ca/publications/mill18.htm )
>
This has come up fairly frequently, and if this technique actually silences
the warnings (I thought GCC's warning was... too "clever" for this), I
think it would be good to document it in
http://llvm.org/docs/ProgrammersManual.html or
http://llvm.org/docs/CodingStandards.html (whichever seems more
appropriate).
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
