>> +#import <Foundation/NSObject.h> Not sure if including <Foundation/NSObject.h> into a test is good idea. Did you check that this tests works and passes on Linux?
--kcc On Wed, Feb 1, 2012 at 7:27 AM, Alexander Potapenko <[email protected]>wrote: > I've added a simple test into CodeGenObjCXX > Looks like ObjC does not support the __attribute__ syntax, so it's > unclear how to prevent a specific function from being instrumented. > > On Tue, Jan 31, 2012 at 10:27 PM, Chandler Carruth <[email protected]> > wrote: > > On Tue, Jan 31, 2012 at 10:21 AM, Kostya Serebryany <[email protected]> > wrote: > >> > >> Could you please also extend the test > >> (cfe/trunk/test/CodeGen/address-safety-attr.cpp)? > >> Ok for me, but I'd prefer to have 'ok' from someone else on the clang > >> side. > > > > > > Your comment is the same as mine -- we should add a test that would fail > > without this change. Otherwise LGTM. =] > > > > -- > Alexander Potapenko > Software Engineer > Google Moscow >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
