On Thu, Feb 2, 2012 at 12:45 PM, Chandler Carruth <[email protected]> wrote: > (switching back to cfe-commits, this isn't an llvm patch...) > > This patch is pretty good. I just want to nit pick a bit w/ the way you're > using FileCheck. It won't cause you problems today, but it may save you some > painful debugging tomorrow to get into this habit. > I used tools/clang/test/CodeGen/address-safety-attr.cpp as a reference, and it seems to misuse CHECK-NOT as well. If the new version of the test is correct, I'll send another patch to fix that.
> Also, just to make me happy about test coverage, want to add the attribute > to another objc construct, and check that we then suppress the LLVM function > attribute in that case? > I don't get it. Do you mean adding the no_address_safety_analysis attribute? The problem is that objc syntax does not support attributes, so I don't know yet how to disable ASan for objc. > Feel free to check in whenever, I or someone else can follow-up in > post-commit review if needed. Thanks for putting up w/ all the comments > here. =] Done. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
