Looks good. On Sat, Feb 18, 2012 at 8:26 PM, Gregory Szorc <[email protected]> wrote: > I've made the implementation of Type.__eq__ more robust and added tests. > > > On Fri, Feb 17, 2012 at 1:37 AM, Manuel Klimek <[email protected]> wrote: >> >> On Fri, Feb 17, 2012 at 8:56 AM, Gregory Szorc <[email protected]> >> wrote: >> > The implementation could probably be a bit more robust (looking for >> > None, comparing types, etc). Do we care? >> >> Regarding looking for None: what happens if one calls t == None on a >> Type? Perhaps add a test? >> >> Cheers, >> /Manuel >> >> >> > --- >> > bindings/python/clang/cindex.py | 10 ++++++++++ >> > bindings/python/tests/cindex/test_type.py | 17 +++++++++++++++++ >> > 2 files changed, 27 insertions(+), 0 deletions(-) >> > >> > _______________________________________________ >> > cfe-commits mailing list >> > [email protected] >> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> > > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
