LGTM. As a very mild stylistic note, you have 'let TargetPrefix = "mips"' for each section in the IntrinsicsMips.td. I suggest just putting that in once surround everything and reducing the indentation level of everything inside it, just like we do for large namespaces in C++ code.
-Jim On Jun 27, 2012, at 7:02 AM, Simon Atanasyan <[email protected]> wrote: > The attached patches define MIPS intrinsics in LLVM and add support > for them to the Clang frontend. Complete MIPS intrinsics implementaion > (code generation, input arguments checking etc) will be finished by > forthcoming patches. > > Please review the patches. > > -- > Simon > <clang.mips-dsp-r1.patch><llvm.mips-dsp-r1.patch>_______________________________________________ > llvm-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
