On Wed, Jun 27, 2012 at 9:19 PM, Jim Grosbach <[email protected]> wrote: > LGTM. > > As a very mild stylistic note, you have 'let TargetPrefix = "mips"' for each > section in the IntrinsicsMips.td. I suggest just putting that in once > surround everything and reducing the indentation level of everything inside > it, just like we do for large namespaces in C++ code.
Thanks for review. I applied suggested changes and submitted patches at r159364 and r159366. -- Simon _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
