This looks good to me. Do you need me to commit it? -Tanya
On Jun 28, 2012, at 7:41 AM, Anton Lokhmotov wrote: > Hi Tanya, > > I've followed your advice and separated code for the work group size > attributes (attached) and the other attributes (to be submitted shortly). > Please review. > > Best wishes, > Anton. > > >> -----Original Message----- >> From: Tanya Lattner [mailto:[email protected]] >> Sent: 23 June 2012 00:35 >> To: Anton Lokhmotov >> Cc: [email protected]; 'Benyei, Guy' >> Subject: Re: [OpenCL patch] Optional attributes >> >> Anton, >> >> I think it may be beneficial to separate out the DummyTypeExpr part >> from this patch and have it reviewed separately. Its the only really >> concerning part from this patch if I remember right. >> >> -Tanya >> >> On Jun 14, 2012, at 4:06 PM, Anton Lokhmotov <[email protected]> >> wrote: >> >>> I would like to return to optional attributes [1]. Here's an update >> with >>> better error handling and tests. Can be a good starting point to >> resume >>> resolving [2]. Please review. >>> >>> Many thanks, >>> Anton. >>> >>> [1] http://lists.cs.uiuc.edu/pipermail/cfe-dev/2012- >> January/019448.html >>> [2] http://lists.cs.uiuc.edu/pipermail/cfe-dev/2012- >> January/019611.html<attributes.patch> > <attributes0.patch> _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
