Committed in r159965. Thank you! -Tanya
On Jul 7, 2012, at 12:21 AM, Anton Lokhmotov wrote: > Thanks Tanya. Yes, please. > > Best regards, > Anton. > > ________________________________________ > From: Tanya Lattner [[email protected]] > Sent: 07 July 2012 01:34 > To: Anton Lokhmotov > Cc: [email protected]; 'Benyei, Guy' > Subject: Re: [OpenCL patch] Optional attributes (non-controversial) > > This looks good to me. Do you need me to commit it? > > -Tanya > > On Jun 28, 2012, at 7:41 AM, Anton Lokhmotov wrote: > >> Hi Tanya, >> >> I've followed your advice and separated code for the work group size >> attributes (attached) and the other attributes (to be submitted shortly). >> Please review. >> >> Best wishes, >> Anton. >> >> >>> -----Original Message----- >>> From: Tanya Lattner [mailto:[email protected]] >>> Sent: 23 June 2012 00:35 >>> To: Anton Lokhmotov >>> Cc: [email protected]; 'Benyei, Guy' >>> Subject: Re: [OpenCL patch] Optional attributes >>> >>> Anton, >>> >>> I think it may be beneficial to separate out the DummyTypeExpr part >>> from this patch and have it reviewed separately. Its the only really >>> concerning part from this patch if I remember right. >>> >>> -Tanya >>> >>> On Jun 14, 2012, at 4:06 PM, Anton Lokhmotov <[email protected]> >>> wrote: >>> >>>> I would like to return to optional attributes [1]. Here's an update >>> with >>>> better error handling and tests. Can be a good starting point to >>> resume >>>> resolving [2]. Please review. >>>> >>>> Many thanks, >>>> Anton. >>>> >>>> [1] http://lists.cs.uiuc.edu/pipermail/cfe-dev/2012- >>> January/019448.html >>>> [2] http://lists.cs.uiuc.edu/pipermail/cfe-dev/2012- >>> January/019611.html<attributes.patch> >> <attributes0.patch> > > > > > -- IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
