Please take another look.

On Tue, Jul 10, 2012 at 9:40 AM, Daniel Jasper <[email protected]> wrote:
> I have tried using it by putting a symlink to compile_commands.json into my
> llvm root and then use clang-check from within <llvm root>/tools/clang like
> this:
>
> $ clang-check lib/Tooling/CompilationDatabase.cpp
> LLVM ERROR: Error while opening JSON database: No such file or directory
>
> It works find if I supply the full path:
> $ ~/clang/build/bin/clang-check $PWD/lib/Tooling/CompilationDatabase.cpp
> Processing:
> /home/djasper/clang/llvm/tools/clang/lib/Tooling/CompilationDatabase.cpp.
>
> So, it does not go up the directory tree far enough, as the
> Directory.empty() will be true before my symlink  is reached. Can this be
> added? And can you add a test for such a case?
>
>   +++ tools/clang/lib/Tooling/CompilationDatabase.cpp (working copy)
>   ...
>   +#include "llvm/Support/raw_ostream.h"
>
> I don't think you need this new include.
>
>
> On Mon, Jul 9, 2012 at 5:49 PM, Alexander Kornienko <[email protected]>
> wrote:
>>
>> Adds the CompilationDatabase::autoDetectFromSource method for supporting
>> build directory auto-detection for simple setups.
>>
>> --
>> Regards,
>> Alexander
>>
>> _______________________________________________
>> cfe-commits mailing list
>> [email protected]
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>
>
> _______________________________________________
> cfe-commits mailing list
> [email protected]
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>

Attachment: build-dir-autodetect.diff
Description: Binary data

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to