Looks good. Nitpicks:
+++ include/clang/Tooling/Tooling.h (working copy) ... +/// \brief Returns the absolute path of 'File', by prepending it with +/// the current directory if 'File' is not absolute. Maybe use \c File instead of 'File'. But I am not sure what's better. +++ lib/Tooling/CompilationDatabase.cpp (working copy) ... + if (CompilationDatabase *DB = loadFromDirectory(Directory, ErrorMessage)) I am not sure that the handling of the ErrorMessage makes much sense. If, e.g. we find a compilation database somewhere that fails to open, we overwrite this with a different error for the parent folder, right? On Tue, Jul 10, 2012 at 11:11 AM, Manuel Klimek <[email protected]> wrote: > Please take another look. > > On Tue, Jul 10, 2012 at 9:40 AM, Daniel Jasper <[email protected]> wrote: > > I have tried using it by putting a symlink to compile_commands.json into > my > > llvm root and then use clang-check from within <llvm root>/tools/clang > like > > this: > > > > $ clang-check lib/Tooling/CompilationDatabase.cpp > > LLVM ERROR: Error while opening JSON database: No such file or directory > > > > It works find if I supply the full path: > > $ ~/clang/build/bin/clang-check $PWD/lib/Tooling/CompilationDatabase.cpp > > Processing: > > /home/djasper/clang/llvm/tools/clang/lib/Tooling/CompilationDatabase.cpp. > > > > So, it does not go up the directory tree far enough, as the > > Directory.empty() will be true before my symlink is reached. Can this be > > added? And can you add a test for such a case? > > > > +++ tools/clang/lib/Tooling/CompilationDatabase.cpp (working copy) > > ... > > +#include "llvm/Support/raw_ostream.h" > > > > I don't think you need this new include. > > > > > > On Mon, Jul 9, 2012 at 5:49 PM, Alexander Kornienko <[email protected]> > > wrote: > >> > >> Adds the CompilationDatabase::autoDetectFromSource method for supporting > >> build directory auto-detection for simple setups. > >> > >> -- > >> Regards, > >> Alexander > >> > >> _______________________________________________ > >> cfe-commits mailing list > >> [email protected] > >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > >> > > > > > > _______________________________________________ > > cfe-commits mailing list > > [email protected] > > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
