On Aug 15, 2012, at 1:39 PM, Richard Smith <[email protected]> wrote:
> The diagnostic message should be sufficient for a typical user to have some
> idea of what is wrong. The current diagnostic does not meet this standard. If
> you explain in a bit more detail what the problem is, maybe someone will be
> able to come up with better diagnostic wording. In any case, diagnostic
> messages should not start with a capital letter.
Agreed. Looking at the warning:
> arning: Use of __private_extern__ on tentative definition has unexpected
> behaviour - use
> __attribute__((visibility("hidden"))) on extern declaration or
> definition instead [-Wprivate-extern]
> __private_extern__ int xyz;
The "unexpected behaviour" (behavior is misspelled) is content free. That's
the part that needs to be elaborated.
The "use __attribute__((visibility("hidden"))) on extern declaration or
definition instead " can be a note on the warning, which allows you to break
the warning up. A FixIt would also be nice.
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
