On Thu, Sep 20, 2012 at 9:42 AM, Sean McBride <[email protected]> wrote:
> Hi All,
>
> Attached are 3 small static analyzer patches:
> - a typo on the website
Typo committed as r164318. The other two patches I'll leave to someone
more familiar with the Static Analyzer.
It might help to resend these with paths that are relative to the
clang directory, rather than absolute. (eg:
---
/Users/smcbride/Documents/Development/llvm/tools/clang/lib/StaticAnalyzer/Checkers/UnixAPIChecker.cpp
(revision
163999)
+++
/Users/smcbride/Documents/Development/llvm/tools/clang/lib/StaticAnalyzer/Checkers/UnixAPIChecker.cpp
(working
copy)
should be
--- lib/StaticAnalyzer/Checkers/UnixAPIChecker.cpp (revision 163999)
+++ lib/StaticAnalyzer/Checkers/UnixAPIChecker.cpp (working copy)
)
Also, these patches seem to lack tests. Could you provide tests?
> - extended the realloc(<zero-size>) check to include reallocf()
> - extended the OSAtomicChecker checker to include 2 other functions of the
> same CompareAndSwap type
>
> I don't know the clang codebase at all and basically made these patches by
> copy-paste while poking around the code. Please review very carefully.
>
> Cheers,
>
> --
> ____________________________________________________________
> Sean McBride, B. Eng [email protected]
> Rogue Research www.rogue-research.com
> Mac Software Developer Montréal, Québec, Canada
>
> _______________________________________________
> cfe-commits mailing list
> [email protected]
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
