On Fri, Sep 21, 2012 at 8:19 AM, Sean McBride <[email protected]> wrote: > On Thu, 20 Sep 2012 14:02:35 -0700, David Blaikie said: > >>The other two patches I'll leave to someone >>more familiar with the Static Analyzer. > > OK... > >>It might help to resend these with paths that are relative to the >>clang directory, rather than absolute. (eg: > > Sorry, that wasn't deliberate... I'll look up the correct svn incantations. > >>Also, these patches seem to lack tests. Could you provide tests? > > Perhaps... as I said, I was merely perusing the analyzer code out of > curiosity I don't really know my way around clang's codebase. But of course > searching for 'OSCompareAndSwap' found what looks like a test in > tools/clang/test/Analysis/NSString.m.... I don't get the relation to > NSString, but I guess I'll add tests for the others there?
I'm not actually familiar with the Static Analyzer's tests either (I mostly work on Clang proper) - but that sounds like a reasonable approach. You can always test your tests by running them with your production code modifications removed to make sure they fail first, then add your changes back in & see if they go from failing to passing. > > Cheers, > > -- > ____________________________________________________________ > Sean McBride, B. Eng [email protected] > Rogue Research www.rogue-research.com > Mac Software Developer Montréal, Québec, Canada > > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
