On Oct 11, 2012, at 4:07 PM, Eric Christopher wrote: >> - .toCharUnitsFromBits(target.getPointerSizeInBits()); >> + .toCharUnitsFromBits(target.getPointerSizeInBits(0)); >> addr.push_back(llvm::ConstantInt::get(Int64Ty, offset.getQuantity())); >> addr.push_back(llvm::ConstantInt::get(Int64Ty, >> llvm::DIBuilder::OpDeref)); >> addr.push_back(llvm::ConstantInt::get(Int64Ty, llvm::DIBuilder::OpPlus)); >> > > I'll acknowledge that I'm not the best example for this, but perhaps > an enum that > is "DefaultAddressSpace" or something less wordy would be a good idea to avoid > magic numbers?
Sounds like a great idea to me. TR 18037 calls this the generic address space, so maybe llvm::GenericAddrSpace? John. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
