Another option is that after we get everything updated, we add back in the default argument as 0 and this issue goes away. I would prefer not to, but just an option.
Micah > -----Original Message----- > From: [email protected] [mailto:cfe-commits- > [email protected]] On Behalf Of Eric Christopher > Sent: Thursday, October 11, 2012 4:08 PM > To: Micah Villmow > Cc: [email protected] > Subject: Re: [cfe-commits] r165726 - > /cfe/trunk/lib/CodeGen/CGDebugInfo.cpp > > > - .toCharUnitsFromBits(target.getPointerSizeInBits()); > > + > .toCharUnitsFromBits(target.getPointerSizeInBits(0)); > > addr.push_back(llvm::ConstantInt::get(Int64Ty, > offset.getQuantity())); > > addr.push_back(llvm::ConstantInt::get(Int64Ty, > llvm::DIBuilder::OpDeref)); > > addr.push_back(llvm::ConstantInt::get(Int64Ty, > llvm::DIBuilder::OpPlus)); > > > > I'll acknowledge that I'm not the best example for this, but perhaps > an enum that > is "DefaultAddressSpace" or something less wordy would be a good idea > to avoid > magic numbers? > > -eric > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
