On Wed, Jan 2, 2013 at 11:17 AM, Krzysztof Parzyszek <[email protected]> wrote: > On 1/2/2013 12:14 PM, David Blaikie wrote: >> >> >> LGTM - though we usually test with clang -cc1 where possible, so I'd >> ask that you change the RUN line of your test to: >> >> // RUN: %clang_cc1 -emit-llvm -triple hexagon-unknown-unknown %s -S -o >> /dev/null >> >> & adding back in the -o /dev/null so we don't create unnecessary >> temporary files. As far as I understand it, the test running >> infrastructure (lit) has the necessary smarts to translate the use of >> /dev/null to something appropriate on each platform. If you look >> around at the regression test suite you'll find many other tests using >> /dev/null for output. > > > Done. > > I had to change the "-target" option to "-triple", as cc1 did not understand > the former.
Yep, sorry, I hadn't highlighted that when I showed the modified RUN line. Please commit. - David > -Krzysztof > > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by > The Linux Foundation _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
