LGTM, you could probably just do metadata {{.*}}, metadata !"bad_carrier",
.... to get rid of some of your check lines.

Couple of stray whitespace changes that make dgregor grumpy though :)

-eric

On Wed, Feb 20, 2013 at 3:20 PM, Adrian Prantl <[email protected]> wrote:

> Hi CFEes,
>
> please review the following patch:
>
> Emit the DIType for ObjC 'id<protocol>' as 'id' rather than objc_object*
> Fix for rdar://problem/12601916.
>
> The frontend treats 'id' as a typedef to an ObjCObjectType,
> whereas 'id<protocol>' is treated as an ObjCPointerType. For the
> debug info, we want to emit 'id' in both cases.
>
> cheers,
> Adrian
>
>
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to