If Eric is OK with debug info. issues, go ahead check it in. - Fariborz On Feb 21, 2013, at 10:50 AM, Adrian Prantl <[email protected]> wrote:
> > On Feb 21, 2013, at 10:07 AM, jahanian <[email protected]> wrote: > >> + // The frontend treats 'id' as a typedef to an ObjCObjectType, >> + // whereas 'id<protocol>' is treated as an ObjCPointerType. For the >> + // debug info, we want to emit 'id' in both cases. >> + QualType PointeeType = Ty->getPointeeType(); >> + if (const ObjCObjectType *Obj = dyn_cast<ObjCObjectType>(PointeeType)) >> + if (Obj->isObjCId() && (Obj->getNumProtocols() > 0)) { >> + return getOrCreateType(CGM.getContext().getObjCIdType(), Unit); >> + } >> >> Please use isObjCQualifiedIdType instead. >> > > That makes the patch even simpler! > > thanks, > adrian > > <0001-Emit-the-DIType-for-ObjC-id-protocol-as-id-rather-th.patch> > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
