Ping? Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
-----Original Message----- From: Weiming Zhao [mailto:[email protected]] Sent: Thursday, January 31, 2013 11:11 AM To: 'Rafael Espíndola' Cc: '[email protected]'; 'Anton Korobeynikov' Subject: RE: [cfe-commits] Fix PR 11326: conflicting mabi between -mabi and -target options on ARM Ping? Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -----Original Message----- From: Weiming Zhao [mailto:[email protected]] Sent: Thursday, December 27, 2012 11:30 AM To: 'Rafael Espíndola' Cc: '[email protected]'; 'Anton Korobeynikov' Subject: RE: [cfe-commits] Fix PR 11326: conflicting mabi between -mabi and -target options on ARM You're right. That line is unnecessary. Originally, I planned to patch the triple. Then, I found that it was unnecessary because ARMABIInfo::computerInfo() will do that. But I forgot the clean up the code. Thanks for the reviewing. Weiming Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -----Original Message----- From: Rafael Espíndola [mailto:[email protected]] Sent: Wednesday, December 26, 2012 8:09 PM To: [email protected] Cc: [email protected]; Anton Korobeynikov Subject: Re: [cfe-commits] Fix PR 11326: conflicting mabi between -mabi and -target options on ARM On 26 December 2012 17:53, Weiming Zhao <[email protected]> wrote: > Hi Rafael, > > Thanks for the review. > I'm attaching the patch which includes test case. Thanks for adding a test for the warning. I think the patch still needs a codegen patch that checks that the value passed to -mabi is actually used. On the implementation itself: Why do you need to patch the triple instead of just changing the code using it to give preference to Opts.ABI? + Opts.Triple = T.getTriple(); This just copies the triple back, no? > Thanks, > weiming Cheers, Rafael _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
