Hi Rafael,

Thanks for reviewing.
The line is needed because Opts.Triple is a string, not a Triple object.

Attached is the rebased patch (no new changes).

Thanks,
Weiming

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by 
The Linux Foundation


-----Original Message-----
From: Rafael Espíndola [mailto:[email protected]] 
Sent: Monday, March 04, 2013 1:29 PM
To: [email protected]
Cc: [email protected]; Anton Korobeynikov
Subject: Re: [cfe-commits] Fix PR 11326: conflicting mabi between -mabi and 
-target options on ARM

On 4 March 2013 16:20, Weiming Zhao <[email protected]> wrote:
> Ping?

+  llvm::Triple T(Opts.Triple);

Can you avoid the copy with something like

const llvm::Triple &T = Opts.Triple?

OK with that change.

Cheers,
Rafael

Attachment: 0004-PR-11326-Lack-diagnosic-message-when-ABI-conflicts-o.patch
Description: Binary data

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to