On Mar 8, 2013, at 2:31 AM, Jiong Wang <[email protected]> wrote: > On 03/08/2013 04:48 AM, Dmitri Gribenko wrote: >> On Thu, Mar 7, 2013 at 6:33 PM, Jiong Wang <[email protected]> wrote: >>> Hi all, >>> >>> Updated the patches for TILE-Gx backend: >>> >>> 1. added initial regression tests for tilegx codegen. >>> 2. added initial regression tests for MC Layer. >>> 3. fixed those commenting style issues. >>> >>> please review, thanks. >> This is a huge patch, and reviewing it in tar.gz is hard. To >> facilitate review process, you can upload this to phabricator. > > OK, I am requesting for a phabricator account. > > one other things is, should I split the patch into several parts? like > > [PATCH 1/10] > [PATCH 2/10] > ... > > because clang patch & test-suite patch is relatively small, but llvm patch > is nearly 10K line, still hard to review. > > if it is, will one patch for one file OK? > > What's the patch policy in llvm community ? > Hi Jiong,
The LLVM community prefers small, self-contained patches. Please split up your patches into small chunks that can be easily reviewed. Keep in mind that the compiler needs to work after each pass goes in. :-) -bw _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
