On Mar 8, 2013, at 3:26 PM, Joerg Sonnenberger <[email protected]> wrote:
> On Fri, Mar 08, 2013 at 11:13:04AM -0800, Bill Wendling wrote: >> The LLVM community prefers small, self-contained patches. Please split >> up your patches into small chunks that can be easily reviewed. Keep in >> mind that the compiler needs to work after each pass goes in. :-) > > Just like with AArch64, this is not a reasonable requirement for a new > backend. The tarball contains essentially three different parts: > (1) Generic changes to recogniz TileGX as triple etc. > (2) The target subdirectory. > (3) The clang logic for va_arg etc. > > While (1) can be and should be split off, it doesn't change match in > terms of patch size, since the majority will stay in item (2). > There are exceptions to every rule. :-) The upshot is that it needs to be fairly easy to review. -bw _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
