================ Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:115 @@ +114,3 @@ + llvm::Constant * + getNullMemberDataPointer(const MemberPointerType *MPT); + ---------------- Fits into one line
================ Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:123 @@ +122,3 @@ + + virtual llvm::Value * + EmitMemberPointerIsNotNull(CodeGenFunction &CGF, ---------------- I think the other declarations don't put the return value on a separate line. ================ Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:376 @@ -353,1 +375,3 @@ +// A null member data pointer is represented as -1 if the class is not +// polymorphic, and 0 otherwise. ---------------- Maybe put the comment inside the function? ================ Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:403 @@ +402,3 @@ + // FIXME: Implement function member pointers. + return GetBogusMemberPointer(QualType(MPT, 0)); +} ---------------- + ErrorUnsupportedABI? http://llvm-reviews.chandlerc.com/D558 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
