On Thu, Mar 21, 2013 at 11:14 PM, John McCall <[email protected]> wrote:
> All these tests are pretty inadequate; you could be accidentally doing > a lot of stuff besides the stores. You should basically be testing the > entire > function body, including the define line. This will also let you > effectively > test that you're generating the right IR type, which will be important when > you start generating different IR types for different cases. > OK, now the alloca and its size is part of the test. That should constrain the size of the member pointer to a single slot. > You're also not testing the generation of a null value. > How so? That's what the final store -1/0 is in each function.
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
