On Fri, Mar 22, 2013 at 1:16 PM, John McCall <[email protected]> wrote:
> On Mar 22, 2013, at 9:58 AM, Reid Kleckner <[email protected]> wrote: > > On Thu, Mar 21, 2013 at 11:14 PM, John McCall <[email protected]> wrote: > >> All these tests are pretty inadequate; you could be accidentally doing >> a lot of stuff besides the stores. You should basically be testing the >> entire >> function body, including the define line. This will also let you >> effectively >> test that you're generating the right IR type, which will be important >> when >> you start generating different IR types for different cases. >> > > OK, now the alloca and its size is part of the test. That should > constrain the size of the member pointer to a single slot. > > > Might as well use CHECK-NEXT for everything after the first alloca line. > Sure, modulo the labels I omitted around the if lowering. With that, feel free to commit, thanks! > Thanks for the review!
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
