Might be nice to see some tests for the inline assembly (front and backend if 
there weren't any there). The Target stuff LGTM otherwise. Someone else will 
need to get the rest of the changes.


================
Comment at: include/clang/AST/ASTContext.h:1583
@@ +1582,3 @@
+  /// global variable with type \p T.
+  unsigned getGlobalAlign(QualType T) const;
+
----------------
Sadly I think most of the rest of llvm is using bits for alignment sizes, so 
you'll probably want to use bits here?


http://llvm-reviews.chandlerc.com/D718
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to