The inline asm tests and system configuration parts LGTM. Probably John will need to approve the rest of codegen.
-eric On Fri, Apr 26, 2013 at 2:28 PM, Richard Sandiford <[email protected]> wrote: > Eric Christopher <[email protected]> writes: >> Might be nice to see some tests for the inline assembly (front and >> backend if there weren't any there). The Target stuff LGTM >> otherwise. Someone else will need to get the rest of the changes. > > Thanks. How does this look? The llvm side already has tests to > make sure that these kinds of asms are handled correctly (although I've > just added a couple more). > >> ================ >> Comment at: include/clang/AST/ASTContext.h:1583 >> @@ +1582,3 @@ >> + /// global variable with type \p T. >> + unsigned getGlobalAlign(QualType T) const; >> + >> ---------------- >> Sadly I think most of the rest of llvm is using bits for alignment >> sizes, so you'll probably want to use bits here? > > OK, I used a getGlobalAlign()/getGlobalAlignInChars() pair instead. > > Richard > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
