(Also, as an aside: please avoid changing the subject line in your emails (such as 'try 3" above) as it breaks threading in some email clients, like gmail) On May 3, 2013 7:09 AM, "Robert Wilhelm" <[email protected]> wrote:
> Thanks for the review. > Mutability is only needed in the ctor. > I have attached new updated patch. > > Robert > > On Fri, 2013-05-03 at 16:08 +0300, Dmitri Gribenko wrote: > > On Fri, May 3, 2013 at 3:59 PM, Robert Wilhelm <[email protected]> > wrote: > > > Hello David, > > > > > > This patch switches to ArrayRef in SemaInit.cpp. > > > > Are you sure that we want to use MultiExprArg? It is a > > MutableArrayRef instead of a plain ArrayRef: > > > > typedef llvm::MutableArrayRef<Expr*> MultiExprArg; > > > > Is mutability needed here? > > > > + for (unsigned I = 0, J= Args.size(); I != J; ++I) > > > > 'J' is not a good name for element count. Please rename J to E and > > add a space before '='. > > > > Expr *InitListAsExpr = InitList; > > - Expr **Args = InitList ? &InitListAsExpr : 0; > > - unsigned NumArgs = InitList ? 1 : 0; > > + MultiExprArg Args(&InitListAsExpr, InitList ? 1 : 0); > > > > No tabs, please. > > > > Dmitri > > > > -- > > main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if > > (j){printf("%d\n",i);}}} /*Dmitri Gribenko <[email protected]>*/ > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
