On Sat, May 4, 2013 at 3:07 AM, jahanian <[email protected]> wrote:
>
> On May 3, 2013, at 5:01 PM, Dmitri Gribenko <[email protected]> wrote:
>
>> On Sat, May 4, 2013 at 2:15 AM, Fariborz Jahanian <[email protected]>
>> wrote:
>>> Modified: cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td?rev=181071&r1=181070&r2=181071&view=diff
>>> ==============================================================================
>>> --- cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td (original)
>>> +++ cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td Fri May 3 18:15:20
>>> 2013
>>> @@ -27,6 +27,10 @@ def backslash_newline_space : Warning<
>>> "backslash and newline separated by space">,
>>> InGroup<DiagGroup<"backslash-newline-escape">>;
>>>
>>> +// comment parsing
>>> +def warn_unknown_comment_command_name : Warning<
>>> + "unknown command tag name">, InGroup<DiagGroup<"comment-command-tag">>;
>>> +
>>
>> This does not belong to the Lex diagnostics. It should go into
>> DiagnosticCommentKinds.td.
>
> But it is a lex kind of diagnostics. But…., I will move it.
Right, for the C++ lexer... I know it is a bit weird, but comment
lexing is separate from C++ lexing. Using 'normal' clang layers is
problematic because comment parsing is essentially invoked from Sema
and we don't want Sema to depend on Lex. So all comment diagnostics
are piled up separately.
Dmitri
--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <[email protected]>*/
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
