No, it doesn't. The only thing that bothers me a bit is that we don't have any tests for this style. There's plenty of tests for LLVM style in form of unit tests, but we still need some kind of file-based integration tests for different style guides.
Anyway, I'm going to commit your patch with getMozillaStyle being based upon getLLVMStyle: http://llvm-reviews.chandlerc.com/D750. If you have any comments, you can share them on Phabricator. On Mon, May 6, 2013 at 3:14 PM, Ehsan Akhgari <[email protected]>wrote: > Does that mean that we can't take this patch in the mean time? > > -- > Ehsan > <http://ehsanakhgari.org/> > > > On Mon, May 6, 2013 at 9:07 AM, Alexander Kornienko <[email protected]>wrote: > >> I'm starting to work on configuration files for clang-format, which are >> going to be a more flexible solution for per-project coding styles. >> >> >> On Sun, May 5, 2013 at 9:28 PM, Ehsan Akhgari >> <[email protected]>wrote: >> >>> Can someone please review and commit this patch? Thanks! >>> >>> -- >>> Ehsan >>> <http://ehsanakhgari.org/> >>> >>> _______________________________________________ >>> cfe-commits mailing list >>> [email protected] >>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >>> >>> >> >> >> -- >> Alexander Kornienko | Software Engineer | [email protected] | +49 151 >> 221 77 957 >> Google Germany GmbH | Dienerstr. 12 | 80331 München >> > > -- Alexander Kornienko | Software Engineer | [email protected] | +49 151 221 77 957 Google Germany GmbH | Dienerstr. 12 | 80331 München
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
