On Mon, May 6, 2013 at 10:06 AM, Alexander Kornienko <[email protected]>wrote:
> No, it doesn't. The only thing that bothers me a bit is that we don't have > any tests for this style. There's plenty of tests for LLVM style in form of > unit tests, but we still need some kind of file-based integration tests for > different style guides. > I think it might make more sense to have tests for individual style properties. That way we wouldn't need to add ad-hoc tests for every project's style. But I would expect that doing that should be easier once the configuration file work you mentioned in done. > Anyway, I'm going to commit your patch with getMozillaStyle being based > upon getLLVMStyle: http://llvm-reviews.chandlerc.com/D750. If you have > any comments, you can share them on Phabricator. > I think the modifications are fine. I personally prefer styles to not be dependent on each other since otherwise a modification to getLLVMStyle may mean that the Mozilla style is now different too, but the number of options are quite small right now so I don't expect that to turn into a problem in practice. Thanks! -- Ehsan <http://ehsanakhgari.org/>
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
