LGTM

================
Comment at: lib/CodeGen/CGCXXABI.h:326
@@ +325,3 @@
+  /// Return whether the given global decl needs a VTT parameter.
+  virtual bool NeedsVTTParameter(GlobalDecl GD);
+
----------------
I think we should eventually move this method completely into ItaniumCXXABI (as 
it doesn't make sense for some other ABIs) but I agree doing this right now 
would require too much of a code change.
Feel free to add a FIXME for that in the comment above.


http://llvm-reviews.chandlerc.com/D821
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to