================
Comment at: test/CodeGenCXX/microsoft-abi-virtual-inheritance.cpp:11
@@ +10,2 @@
+
+C::C() {}
----------------
Reid Kleckner wrote:
> You could check the mangling here to assert that we don't add the hidden
> parameter, right?
I'm not sure how useful this would be; the Itanium ABI doesn't mangle the VTT
and these checks should essentially become part of the vbtable tests.
================
Comment at: test/CodeGenCXX/microsoft-abi-virtual-inheritance.cpp:1
@@ +1,2 @@
+// RUN: %clang_cc1 %s -fno-rtti -cxx-abi microsoft -triple=i386-pc-win32
-emit-llvm -o %t
+
----------------
Timur Iskhodzhanov wrote:
> Reid Kleckner wrote:
> > I'd roll this into the microsoft-abi-structors.cpp test case
> Please note that structors for virtual inheritance can be more complex than
> usual structors (e.g. think vtordisp), so I think it'd be reasonable to have
> a separate file in a long term.
*shrug* I'll leave this as is. Whoever works on more test cases can decide
whether to keep the split.
http://llvm-reviews.chandlerc.com/D821
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
