================
Comment at: lib/Driver/Tools.cpp:1605
@@ +1604,3 @@
+    D.Diag(diag::err_drv_argument_not_allowed_with)
+      << lastArgumentForKind(D, Args, Leak)
+      << lastArgumentForKind(D, Args, NeedsTsanRt);
----------------
Alexey Samsonov wrote:
> Why not NeedsLeakDetection here?
ok

================
Comment at: lib/Driver/Tools.cpp:1609
@@ +1608,3 @@
+    D.Diag(diag::err_drv_argument_not_allowed_with)
+      << lastArgumentForKind(D, Args, Leak)
+      << lastArgumentForKind(D, Args, NeedsMsanRt);
----------------
Alexey Samsonov wrote:
> and here
ok

================
Comment at: lib/Driver/Tools.cpp:1718
@@ -1708,4 +1717,3 @@
       addSanitizerRTLinkFlagsLinux(TC, Args, CmdArgs, "asan", true);
-    }
   }
 }
----------------
Alexey Samsonov wrote:
> So, what about flipping the default leak detection on/off in presence of 
> -fsanitize=address,leaks?
added a fixme


http://llvm-reviews.chandlerc.com/D837
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to