On Thu, May 23, 2013 at 2:02 PM, Rui Ueyama <[email protected]> wrote: > - Consumer.HandleDependentLibrary(Arg); > + // If the argument does not end in .lib, automatically add the > suffix. This > + // matches the behavior of MSVC. > + std::string ArgStr = Arg; > + StringRef End = Arg.substr( Arg.size() - 4 ); > > Looks like it's not safe if Arg.size() < 4. >
Please use StringRef::endswith for this.
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
