LGTM
On Thu, May 23, 2013 at 6:51 PM, Aaron Ballman <[email protected]>wrote: > Modified portion of the patch is: > > // If the argument does not end in .lib, automatically add the suffix. > This > // matches the behavior of MSVC. > std::string ArgStr = Arg; > if (Arg.size() <= 4 || > Arg.substr(Arg.size() - 4).compare_lower(".lib") != 0) { > ArgStr += ".lib"; > } > Consumer.HandleDependentLibrary(ArgStr); > return; > > ~Aaron > > On Thu, May 23, 2013 at 5:07 PM, Aaron Ballman <[email protected]> > wrote: > > On Thu, May 23, 2013 at 5:05 PM, Aaron Ballman <[email protected]> > wrote: > >> On Thu, May 23, 2013 at 5:02 PM, Rui Ueyama <[email protected]> wrote: > >>> - Consumer.HandleDependentLibrary(Arg); > >>> + // If the argument does not end in .lib, automatically add the > suffix. > >>> This > >>> + // matches the behavior of MSVC. > >>> + std::string ArgStr = Arg; > >>> + StringRef End = Arg.substr( Arg.size() - 4 ); > >>> > >>> Looks like it's not safe if Arg.size() < 4. > >> > >> Hmm, that's a good point due to the unsigned subtraction. Easy enough > >> to resolve. > > > > Also, just caught the formatting issue with the extra spaces; also > > easy enough to resolve. > > > > ~Aaron >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
