On Wed, Jun 12, 2013, Arthur O'Dwyer <[email protected]> wrote: > On Fri, Jun 7, 2013 at 4:46 PM, John McCall <[email protected]> wrote: >> On Jun 7, 2013, at 4:42 PM, Arthur O'Dwyer <[email protected]> wrote: >>> >>> Fixed. I renamed this variable to SmallStructsConvention and the enum to >>> SmallStructsConventionKind to save a bit of horizontal space. >>> I removed the "default: assert(false);" case in my helper function, as it >>> was >>> now triggering a warning from -Wcovered-switch-default. >> >> How about "StructReturnConventionKind"? > > Fixed, although I realized afterward that this changes "SSC_" to "SRC_", > which is slightly unfortunate ("SRC" being short for "source" in other > contexts).
Pinged rjmccall on Wednesday. Is there anything preventing this patch from going in, at this point? I've attached two versions of the patch: one with SRC_OnStack and SRC_InRegs, and one with SRCK_OnStack and SRCK_InRegs. There's no other difference between them. I believe I prefer the SRCK_ version; thanks, Jordan! -Arthur
fpcc-struct-return-v4.diff
Description: Binary data
fpcc-struct-return-v4-SRCK.diff
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
