I suppose that system's python should be /usr/bin/python in Cygwin's world. I didn't know Python/win32 could run Lit for cygwin tests.
What is a motivation for you to take *external* python on cygwin? 2013/7/30 Hans Wennborg <[email protected]>: > I use the system's Python, maybe that's why we get different results: > > $ /cygdrive/c/python_26_amd64/files/python bin/llvm-lit -v > ../tools/clang/test/Driver/cl.c > -- Testing: 1 tests, 1 threads -- > UNSUPPORTED: Clang :: Driver/cl.c (1 of 1) > Testing Time: 0.00s > Unsupported Tests : 1 > llvm-lit: lit.cfg:184: note: using clang: > 'D:/src/llvm/build.debug/bin/./clang.EXE' > > In my case, lit.getBashPath() returns "C:\src\cygwin\bin\bash.EXE". > > Do you think my patch is OK? > > > On Mon, Jul 29, 2013 at 10:34 AM, NAKAMURA Takumi <[email protected]> > wrote: >> Hans, I am certain it would be less useful on cygwin. >> >> Python 2.6.8 (unknown, Jun 9 2012, 11:30:32) >>>>> import platform >>>>> platform.system() >> 'CYGWIN_NT-6.1-WOW64' >> >> I can see "shell-preserves-root" is enabled on cygwin. >> >> PASS: Clang :: Driver/cl.c (2638 of 6275) >> >> Which version of python are you using on cygwin? >> >> >> 2013/7/30 Hans Wennborg <[email protected]>: >>> Hi, >>> >>> The attached patch tightens the "shell-preserves-root" feature check >>> in lit.cfg. Previously, the check would exclude this feature also on >>> Cygwin, but as the comment suggests, I think it should only check for >>> MSYS. >>> >>> With this patch, the number of unsupported tests on Cygwin go from 35 to 32. >>> >>> I was not able to test this on MSYS. Takumi, could you give it a try? >>> >>> Thanks, >>> Hans _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
