OK, I committed r187737. Thanks, Hans
On Mon, Aug 5, 2013 at 12:58 PM, Reid Kleckner <[email protected]> wrote: > I'd just go for it. That patch looks fine and should have very low risk. > > > On Mon, Aug 5, 2013 at 10:40 AM, Hans Wennborg <[email protected]> wrote: >> >> On Tue, Jul 30, 2013 at 3:56 PM, Hans Wennborg <[email protected]> wrote: >> > On Mon, Jul 29, 2013 at 6:07 PM, Hans Wennborg <[email protected]> >> > wrote: >> >> On Mon, Jul 29, 2013 at 3:28 PM, Reid Kleckner <[email protected]> wrote: >> >>> bash -help is pretty fast to start, but it also seems pretty >> >>> heavyweight for >> >>> lit.cfg. It's probably better to check not execute_external like >> >>> this: >> >>> >> >>> $ git diff test/lit.cfg >> >>> diff --git a/test/lit.cfg b/test/lit.cfg >> >>> index a5bb350..f2f16fb 100644 >> >>> --- a/test/lit.cfg >> >>> +++ b/test/lit.cfg >> >>> @@ -245,7 +245,7 @@ if execute_external: >> >>> config.available_features.add('shell') >> >>> >> >>> # Exclude MSYS due to transforming '/' to 'X:/mingwroot/'. >> >>> -if not platform.system() in ['Windows'] or lit.getBashPath() == '': >> >>> +if not platform.system() in ['Windows'] or not execute_external: >> >>> config.available_features.add('shell-preserves-root') >> >> >> >> That sounds good to me. Takumi, what do you think about this change? I >> >> see we do (almost) the same check earlier in the file, in >> >> getClangBuiltinIncludeDir(). >> > >> > Ping? >> >> Ping? > > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
