I think generally this looks great. To your questions: 1. why would you use a pair instead? it seems to me like range is strictly better here, so maybe I'm missing something 2. I think dedup and conflict detection in one is fine - I can't imagine only wanting to do one 3. the fixme would be fixed once the Replacements typedef is changed, and RefactoringTool is adapted - I'd strongly vote for doing that in a different patch though.
http://llvm-reviews.chandlerc.com/D1314 BRANCH dedup ARCANIST PROJECT clang _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
