On Thu, Aug 8, 2013 at 6:14 AM, Edwin Vane <[email protected]> wrote:
> > 1. I was concerned that although `Range` describes what I want that my > use of it to describe an offset and number of consecutive items in a vector > was against it's intended use as a **source** range. > Ooooh. Ok, I assumed the output of vector<Range> conflict would be overlapping *source* ranges (apparently I didn't read closely enough, no idea how I convinced myself that this makes sense :P) In that case I'd suggest to either: - use pair - report conflicts as source ranges (which I'd personally prefer) obviously fine as a follow-up patch. Thanks! /Manuel > 2. Just making sure. When we switch `Replacements` to be an > `std::vector` from `std::set` when deduplication happens this new function > would be used which is doing something new from before: i.e. conflict > detection. > 3. That was the intention. > > So ready to commit? > > http://llvm-reviews.chandlerc.com/D1314 > > BRANCH > dedup > > ARCANIST PROJECT > clang >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
